Nswag adds null check for nullable/optional parameters

By -

I have basically same issue as this (details here on Github) but with C# client - [FromForm] SomeObject x on controller has some nullable (optional) parameters and generated client generated by Nswag has null checks in place like this:

public virtual async System.Threading.Tasks.Task<Attachment> UploadAsync(int? idProject = null, int? idTicket = null...
...
if (idProject == null) throw new System.ArgumentNullException("idProject");
else
{
    content_.Add(new System.Net.Http.StringContent(ConvertToString(idProject, System.Globalization.CultureInfo.InvariantCulture)), "IdProject");
}
...

Both original model (from API project) and generated one in client project have those fields as nullable and function call accepts nullable values.

JSON schema from swagger looks like this:

"/Attachment/Upload": {
  "post": {
    "tags": [
      "Attachment"
    ],
    "requestBody": {
      "content": {
        "multipart/form-data": {
          "schema": {
            "required": [
              "Name"
            ],
            "type": "object",
            "properties": {
              "IdProject": {
                "type": "integer",
                "format": "int32"
              },
              "IdTicket": {
                "type": "integer",
                "format": "int32"
              },...

I've tried setting "queryNullValue": "" in openApiToCSharpClient but it does not help. How to disable those checks in generated client? I must use [FromForm] since I'm sending both file(s) and some additional data with them.

Nswag file (generator settings only):

"openApiToCSharpClient": {
  "generateClientInterfaces": true,
  "GenerateClientClasses": true,
  "useBaseUrl": false,
  "namespace": "xxxxxxxx.APIClient",
  "className": "{controller}Client",
  "operationGenerationMode": "MultipleClientsFromFirstTagAndOperationName",
  "jsonLibrary": "SystemTextJson",
  "generateDtoTypes": true,
  "disposeHttpClient": true,
  "injectHttpClient": true,
  "httpClientType": "System.Net.Http.HttpClient",
  "UseHttpRequestMessageCreationMethod": false,
  "generateBaseUrlProperty": false,
  "generateOptionalParameters": true,
  "parameterArrayType": "System.Collections.Generic.IReadOnlyList",
  "responseArrayType": "System.Collections.Generic.IReadOnlyList",
  "generateOptionalPropertiesAsNullable": true,
  "generateNullableReferenceTypes": true,
  "output": "Client.g.cs",
  "generateExceptionClasses": true,
  "dateType": "System.DateTime",
  "dateTimeType": "System.DateTime",
  "queryNullValue": "",
  "additionalNamespaceUsages": [
    "global::APIClient"
  ]
}


Comments

Post a Comment

Popular posts from this blog

Today Walkin 14th-Sept

By -
Image
14th Sept 2017 ( GO Through all List) Read Walkin details properly , Try to call company before attending if possible !!! ==================================== 1. Myntra through fresherworld (Call Based , Venue shared to shortlisted candidates) _____________________________ 2. Magna : Hiring for Client Harman : C++
Read more

Spring Elasticsearch Operations

By -
Elasticsearch Operations Spring Data Elasticsearch uses two interfaces to define the operations that can be called against an Elasticsearch index. These are ElasticsearchOperations and ReactiveElasticsearchOperations. Whereas the first is used with the classic synchronous implementations, the second one uses reactive infrastructure. The default implementations of the interfaces offer: Read/Write mapping support for domain types. A rich query and criteria api. Resource management and Exception translation. ElasticsearchTemplate The ElasticsearchTemplate is an implementation of the ElasticsearchOperations interface using the Transport Client. @Configuration public class TransportClientConfig extends ElasticsearchConfigurationSupport {   @Bean   public Client elasticsearchClient() throws UnknownHostException {                      Settings settings = Settings.builder().put("cluster.name", "elasticsearch")....
Read more

Hibernate Search - Elasticsearch with JSON manipulation

By -
Elasticsearch with JSON manipulation Elasticsearch ships with many features. It is possible that at some point, one feature you need will not be exposed by the Search DSL. To work around such limitations, Hibernate Search provides ways to: Transform the HTTP request sent to Elasticsearch for search queries. Read the raw JSON of the HTTP response received from Elasticsearch for search queries. Direct changes to the HTTP request may conflict with Hibernate Search features and be supported differently by different versions of Elasticsearch. Similarly, the content of the HTTP response may change depending on the version of Elasticsearch, depending on which Hibernate Search features are used, and even depending on how Hibernate Search features are implemented. Thus, features relying on direct access to HTTP requests or responses cannot be guaranteed to continue to work when upgrading Hibernate Search, even for micro upgrades (x.y.z to x.y.(z+1)). Use this at your own risk....
Read more